| Date | Sun, 23 Jun 2019 17:23:19 +0200 | From | Andrew Lunn <> | Subject | Re: [PATCH 10/15] ARM: orion5x: cleanup cppcheck shifting errors |
| |
On Sun, Jun 23, 2019 at 10:13:08PM +0700, Phong Tran wrote: > [arch/arm/mach-orion5x/pci.c:281]: (error) Shifting signed 32-bit value > by 31 bits is undefined behaviour > [arch/arm/mach-orion5x/pci.c:305]: (error) Shifting signed 32-bit value > by 31 bits is undefined behaviour > > Signed-off-by: Phong Tran <tranmanphong@gmail.com>
Maybe using the BIT() macro would be better, but this is O.K.
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
|