lkml.org 
[lkml]   [2019]   [Jun]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH 10/15] ARM: orion5x: cleanup cppcheck shifting errors
    Date
    Hi Phong,

    > [arch/arm/mach-orion5x/pci.c:281]: (error) Shifting signed 32-bit value
    > by 31 bits is undefined behaviour
    > [arch/arm/mach-orion5x/pci.c:305]: (error) Shifting signed 32-bit value
    > by 31 bits is undefined behaviour
    >

    While Andrew was Ok with this version, I will wait for your v2 using
    BIT() marcro.

    Thanks,

    Gregory


    > Signed-off-by: Phong Tran <tranmanphong@gmail.com>
    > ---
    > arch/arm/mach-orion5x/pci.c | 8 ++++----
    > 1 file changed, 4 insertions(+), 4 deletions(-)
    >
    > diff --git a/arch/arm/mach-orion5x/pci.c b/arch/arm/mach-orion5x/pci.c
    > index 76951bfbacf5..1b2c077ee7b8 100644
    > --- a/arch/arm/mach-orion5x/pci.c
    > +++ b/arch/arm/mach-orion5x/pci.c
    > @@ -200,13 +200,13 @@ static int __init pcie_setup(struct pci_sys_data *sys)
    > /*
    > * PCI_MODE bits
    > */
    > -#define PCI_MODE_64BIT (1 << 2)
    > -#define PCI_MODE_PCIX ((1 << 4) | (1 << 5))
    > +#define PCI_MODE_64BIT (1U << 2)
    > +#define PCI_MODE_PCIX ((1U << 4) | (1U << 5))
    >
    > /*
    > * PCI_CMD bits
    > */
    > -#define PCI_CMD_HOST_REORDER (1 << 29)
    > +#define PCI_CMD_HOST_REORDER (1U << 29)
    >
    > /*
    > * PCI_P2P_CONF bits
    > @@ -223,7 +223,7 @@ static int __init pcie_setup(struct pci_sys_data *sys)
    > #define PCI_CONF_FUNC(func) (((func) & 0x3) << 8)
    > #define PCI_CONF_DEV(dev) (((dev) & 0x1f) << 11)
    > #define PCI_CONF_BUS(bus) (((bus) & 0xff) << 16)
    > -#define PCI_CONF_ADDR_EN (1 << 31)
    > +#define PCI_CONF_ADDR_EN (1U << 31)
    >
    > /*
    > * Internal configuration space
    > --
    > 2.11.0
    >

    --
    Gregory Clement, Bootlin
    Embedded Linux and Kernel engineering
    http://bootlin.com

    \
     
     \ /
      Last update: 2019-06-24 09:32    [W:5.601 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site