Messages in this thread Patch in this message | | | Date | Wed, 19 Jun 2019 11:02:07 -0500 | From | "Gustavo A. R. Silva" <> | Subject | [PATCH][bpf] bpf: verifier: add break statement in switch |
| |
Notice that in this case, it's much clearer to explicitly add a break rather than letting the code to fall through. It also avoid potential future fall-through warnings[1].
This patch is part of the ongoing efforts to enable -Wimplicit-fallthrough.
[1] https://lore.kernel.org/patchwork/patch/1087056/
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- kernel/bpf/verifier.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/kernel/bpf/verifier.c b/kernel/bpf/verifier.c index d2c8a6677ac4..0acf7c569ec6 100644 --- a/kernel/bpf/verifier.c +++ b/kernel/bpf/verifier.c @@ -5365,6 +5365,7 @@ static int check_return_code(struct bpf_verifier_env *env) if (env->prog->expected_attach_type == BPF_CGROUP_UDP4_RECVMSG || env->prog->expected_attach_type == BPF_CGROUP_UDP6_RECVMSG) range = tnum_range(1, 1); + break; case BPF_PROG_TYPE_CGROUP_SKB: case BPF_PROG_TYPE_CGROUP_SOCK: case BPF_PROG_TYPE_SOCK_OPS: -- 2.21.0
| |