Messages in this thread | | | Date | Tue, 18 Jun 2019 15:10:31 +0100 | From | Jonathan Cameron <> | Subject | Re: [PATCH v4 10/22] iommu: Fix compile error without IOMMU_API |
| |
On Sun, 9 Jun 2019 06:44:10 -0700 Jacob Pan <jacob.jun.pan@linux.intel.com> wrote:
> struct page_response_msg needs to be defined outside CONFIG_IOMMU_API.
What was the error?
If this is a fix for an earlier patch in this series role it in there (or put it before it). If more general we should add a fixes tag.
Jonathan > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> > --- > include/linux/iommu.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/include/linux/iommu.h b/include/linux/iommu.h > index 7a37336..8d766a8 100644 > --- a/include/linux/iommu.h > +++ b/include/linux/iommu.h > @@ -189,8 +189,6 @@ struct iommu_sva_ops { > iommu_mm_exit_handler_t mm_exit; > }; > > -#ifdef CONFIG_IOMMU_API > - > /** > * enum page_response_code - Return status of fault handlers, telling the IOMMU > * driver how to proceed with the fault. > @@ -227,6 +225,7 @@ struct page_response_msg { > u64 iommu_data; > }; > > +#ifdef CONFIG_IOMMU_API > /** > * struct iommu_ops - iommu ops and capabilities > * @capable: check capability
| |