Messages in this thread | | | Subject | Re: [PATCH v4 16/22] iommu/vt-d: Move domain helper to header | From | Auger Eric <> | Date | Tue, 16 Jul 2019 11:33:16 +0200 |
| |
Hi Jacob, On 6/9/19 3:44 PM, Jacob Pan wrote: > Move domainer helper to header to be used by SVA code. > > Signed-off-by: Jacob Pan <jacob.jun.pan@linux.intel.com> > --- > drivers/iommu/intel-iommu.c | 6 ------ > include/linux/intel-iommu.h | 6 ++++++ > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/iommu/intel-iommu.c b/drivers/iommu/intel-iommu.c > index 39b63fe..7cfa0eb 100644 > --- a/drivers/iommu/intel-iommu.c > +++ b/drivers/iommu/intel-iommu.c > @@ -427,12 +427,6 @@ static void init_translation_status(struct intel_iommu *iommu) > iommu->flags |= VTD_FLAG_TRANS_PRE_ENABLED; > } > > -/* Convert generic 'struct iommu_domain to private struct dmar_domain */ > -static struct dmar_domain *to_dmar_domain(struct iommu_domain *dom) > -{ > - return container_of(dom, struct dmar_domain, domain); > -} > - > static int __init intel_iommu_setup(char *str) > { > if (!str) > diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h > index 8605c74..b75f17d 100644 > --- a/include/linux/intel-iommu.h > +++ b/include/linux/intel-iommu.h > @@ -597,6 +597,12 @@ static inline void __iommu_flush_cache( > clflush_cache_range(addr, size); > } > > +/* Convert generic 'struct iommu_domain to private struct dmar_domain */ fix the single '? > +static inline struct dmar_domain *to_dmar_domain(struct iommu_domain *dom) > +{ > + return container_of(dom, struct dmar_domain, domain); > +} > + > /* > * 0: readable > * 1: writable > Reviewed-by: Eric Auger <eric.auger@redhat.com>
Thanks
Eric
| |