Messages in this thread | | | From | Arnd Bergmann <> | Date | Mon, 17 Jun 2019 14:12:48 +0200 | Subject | Re: [PATCH] mtd: rawnand: ingenic: fix ingenic_ecc dependency |
| |
On Mon, Jun 17, 2019 at 1:24 PM Paul Cercueil <paul@crapouillou.net> wrote:
> I think there's a better way to fix it, only in Kconfig. > > * Add a bool symbol MTD_NAND_INGENIC_USE_HW_ECC > * Have the three ECC/BCH drivers select this symbol instead of > MTD_NAND_INGENIC_ECC > * Add the following to the MTD_NAND_JZ4780 config option: > "select MTD_NAND_INGENIC_ECC if MTD_NAND_INGENIC_USE_HW_ECC"
I don't see much difference to my approach here, but if you want to submit that version with 'Reported-by: Arnd Bergmann <arnd@arndb.de>', please do so.
Yet another option would be to use Makefile code to link both files into one module, and remove the EXPORT_SYMBOL statements:
obj-$(CONFIG_MTD_NAND_JZ4780) += jz4780_nand.o jz4780_nand-y += ingenic_nand.o jz4780_nand-$(CONFIG_MTD_NAND_INGENIC_ECC) += ingenic_ecc.o
Arnd
| |