lkml.org 
[lkml]   [2019]   [Jun]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mtd: rawnand: ingenic: fix ingenic_ecc dependency
    Hello,

    Arnd Bergmann <arnd@arndb.de> wrote on Mon, 17 Jun 2019 14:12:48 +0200:

    > On Mon, Jun 17, 2019 at 1:24 PM Paul Cercueil <paul@crapouillou.net> wrote:
    >
    > > I think there's a better way to fix it, only in Kconfig.
    > >
    > > * Add a bool symbol MTD_NAND_INGENIC_USE_HW_ECC
    > > * Have the three ECC/BCH drivers select this symbol instead of
    > > MTD_NAND_INGENIC_ECC
    > > * Add the following to the MTD_NAND_JZ4780 config option:
    > > "select MTD_NAND_INGENIC_ECC if MTD_NAND_INGENIC_USE_HW_ECC"
    >
    > I don't see much difference to my approach here, but if you want
    > to submit that version with 'Reported-by: Arnd Bergmann <arnd@arndb.de>',
    > please do so.
    >
    > Yet another option would be to use Makefile code to link both
    > files into one module, and remove the EXPORT_SYMBOL statements:
    >
    > obj-$(CONFIG_MTD_NAND_JZ4780) += jz4780_nand.o
    > jz4780_nand-y += ingenic_nand.o
    > jz4780_nand-$(CONFIG_MTD_NAND_INGENIC_ECC) += ingenic_ecc.o
    >

    I personally have a preference for this one.

    Thanks,
    Miquèl

    \
     
     \ /
      Last update: 2019-06-17 14:18    [W:3.293 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site