| From | Greg Kroah-Hartman <> | Subject | [PATCH 5.1 004/115] HID: input: fix assignment of .value | Date | Mon, 17 Jun 2019 23:08:24 +0200 |
| |
From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
commit 39b3c3a5fbc5d744114e497d35bf0c12f798c134 upstream.
The value field is actually an array of .maxfield. We should assign the correct number to the correct usage.
Not that we never encounter a device that requires this ATM, but better have the proper code path.
Fixes: 2dc702c991e377 ("HID: input: use the Resolution Multiplier for high-resolution scrolling") Cc: stable@vger.kernel.org # v5.0+ Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
--- drivers/hid/hid-input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/hid/hid-input.c +++ b/drivers/hid/hid-input.c @@ -1595,7 +1595,7 @@ static bool __hidinput_change_resolution if (usage->hid != HID_GD_RESOLUTION_MULTIPLIER) continue; - *report->field[i]->value = value; + report->field[i]->value[j] = value; update_needed = true; } }
|