Messages in this thread | | | From | Akinobu Mita <> | Date | Thu, 9 May 2019 00:56:24 +0900 | Subject | Re: [PATCH v2 6/7] nvme-pci: add device coredump support |
| |
2019年5月8日(水) 6:28 Keith Busch <kbusch@kernel.org>: > > On Tue, May 07, 2019 at 02:31:41PM -0600, Heitke, Kenneth wrote: > > On 5/7/2019 10:58 AM, Akinobu Mita wrote: > > > + > > > +static int nvme_get_telemetry_log_blocks(struct nvme_ctrl *ctrl, void *buf, > > > + size_t bytes, loff_t offset) > > > +{ > > > + const size_t chunk_size = ctrl->max_hw_sectors * ctrl->page_size; > > > > Just curious if chunk_size is correct since page size and block size can > > be different. > > They're always different. ctrl->page_size is hard-coded to 4k, while > sectors are always 512b.
Oops. I misunderstood how ctrl->max_hw_sectors is initialized from MDTS. Also overflow check was required here for the architectures that use "unsigned int" size_t.
| |