lkml.org 
[lkml]   [2019]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v2 6/7] nvme-pci: add device coredump support
    From
    Date


    On 5/7/2019 10:58 AM, Akinobu Mita wrote:
    > +
    > +static int nvme_get_telemetry_log_blocks(struct nvme_ctrl *ctrl, void *buf,
    > + size_t bytes, loff_t offset)
    > +{
    > + const size_t chunk_size = ctrl->max_hw_sectors * ctrl->page_size;

    Just curious if chunk_size is correct since page size and block size can
    be different.


    > + loff_t pos = 0;
    > +
    > + while (pos < bytes) {
    > + size_t size = min_t(size_t, bytes - pos, chunk_size);
    > + int ret;
    > +
    > + ret = nvme_get_log(ctrl, NVME_NSID_ALL, NVME_LOG_TELEMETRY_CTRL,
    > + 0, buf + pos, size, offset + pos);
    > + if (ret)
    > + return ret;
    > +
    > + pos += size;
    > + }
    > +
    > + return 0;
    > +}

    \
     
     \ /
      Last update: 2019-05-07 22:32    [W:2.782 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site