lkml.org 
[lkml]   [2019]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subjectstm class: Prevent user-controllable allocations

It seems to me that we still allow overflow if count == ~0. We'll then
allocate 0 bytes but copy ~0 bytes. That does not sound healthy.

Fixes: f08b18266c7116e2ec6885dd53a928f580060a71

Signed-off-by: Pavel Machek <pavel@denx.de>

diff --git a/drivers/hwtracing/stm/core.c b/drivers/hwtracing/stm/core.c
index c7ba8ac..8846fca 100644
--- a/drivers/hwtracing/stm/core.c
+++ b/drivers/hwtracing/stm/core.c
@@ -631,7 +631,7 @@ static ssize_t stm_char_write(struct file *file, const char __user *buf,
char *kbuf;
int err;

- if (count + 1 > PAGE_SIZE)
+ if (count > PAGE_SIZE - 1)
count = PAGE_SIZE - 1;

/*
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-05-07 14:42    [W:0.028 / U:0.868 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site