lkml.org 
[lkml]   [2019]   [May]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: linux-5.1/drivers/thermal/qcom/tsens-v2.c:54]: bad assignment ?
On Tue, May 7, 2019 at 3:40 PM David Binderman <dcb314@hotmail.com> wrote:
>
> Hello there,
>
>
> linux-5.1/drivers/thermal/qcom/tsens-v2.c:54]: (style) Assignment 'last_temp=last_temp2' is redundant with condition 'last_temp==last_temp2'.
>
> Source code is
>
>
> if (last_temp == last_temp2)
> last_temp = last_temp2;
>
> Suggest code rework.
>
> Regards
>
> David Binderman

Hi David,

Thanks for the report. That was an old version of the function from
downstream. I've now refactored it and resubmitted it here:

https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1922871.html

Regards,
Amit

\
 
 \ /
  Last update: 2019-05-07 12:29    [W:0.018 / U:0.664 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site