Messages in this thread | | | Date | Tue, 7 May 2019 15:02:44 -0500 | From | Josh Poimboeuf <> | Subject | Re: [RFC][PATCH 2/3] x86_64: Allow breakpoints to emulate call functions |
| |
On Tue, May 07, 2019 at 03:58:17PM -0400, Steven Rostedt wrote: > On Tue, 7 May 2019 14:49:25 -0500 > Josh Poimboeuf <jpoimboe@redhat.com> wrote: > > > > New version: > > > > > > x86_64: Allow breakpoints to emulate call functions > > > > > > In order to allow breakpoints to emulate call functions, they need to push > > > > Sorry to keep nitpicking, but "call functions" -> "function calls" would > > sound more accurate to me (in both subject and description). > > I disagree ;-) > > Matters how you look at it. I look at it as emulating the "call" > function, not a function call. Like emulating an "addl" function, or a > "jmp" function. > > See?
I kind of see your point... but then you're overloading the meaning of the word "function", in a context where it clearly means something else.
> To remove the ambiguity, I could replace "function" with "instruction".
Yes, that would be much better :-)
-- Josh
| |