Messages in this thread | | | Date | Tue, 7 May 2019 15:58:17 -0400 | From | Steven Rostedt <> | Subject | Re: [RFC][PATCH 2/3] x86_64: Allow breakpoints to emulate call functions |
| |
On Tue, 7 May 2019 14:49:25 -0500 Josh Poimboeuf <jpoimboe@redhat.com> wrote:
> > New version: > > > > x86_64: Allow breakpoints to emulate call functions > > > > In order to allow breakpoints to emulate call functions, they need to push > > Sorry to keep nitpicking, but "call functions" -> "function calls" would > sound more accurate to me (in both subject and description).
I disagree ;-)
Matters how you look at it. I look at it as emulating the "call" function, not a function call. Like emulating an "addl" function, or a "jmp" function.
See?
To remove the ambiguity, I could replace "function" with "instruction".
> > Otherwise it looks good.
Thanks!
-- Steve
| |