Messages in this thread | | | Date | Tue, 7 May 2019 20:12:23 +0200 | From | Sam Ravnborg <> | Subject | Re: [PATCH v10 2/2] phy: Add driver for mixel mipi dphy found on NXP's i.MX8 SoCs |
| |
Hi Guido.
Looks good now, stumbled upon a few details I missed in last round. With these considered / fixed you can add my Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Sam
> +#define CM(x) ( \ > + ((x) < 32)?0xe0|((x)-16) : \ > + ((x) < 64)?0xc0|((x)-32) : \ > + ((x) < 128)?0x80|((x)-64) : \ > + ((x) - 128)) > +#define CN(x) (((x) == 1)?0x1f : (((CN_BUF)>>((x)-1))&0x1f)) > +#define CO(x) ((CO_BUF)>>(8-(x))&0x3)
A few spaces around the operators may help readability a little.
> +static int phy_write(struct phy *phy, u32 value, unsigned int reg) > +{ > + struct mixel_dphy_priv *priv = phy_get_drvdata(phy); > + int ret; > + > + ret = regmap_write(priv->regmap, reg, value); > + if (ret < 0) > + dev_err(&phy->dev, "Failed to write DPHY reg %d: %d", reg, ret);
I have recently learned that one has to remember trailign "\n"- please add. Check all other dev_xxx as I noticed the newline is missing in a few more places.
> + > + dev_dbg(&phy->dev, "hs_clk/ref_clk=%ld/%ld ⩰ %d/%d\n", ^
There was another of the symbols my terminal cannot show.
| |