Messages in this thread | | | Subject | Re: [PATCH 2/2] usbip: Remove repeated setting of hcd->state in vhci_bus_resume() | From | shuah <> | Date | Mon, 6 May 2019 09:16:00 -0600 |
| |
On 5/6/19 6:55 AM, Suwan Kim wrote: > When hcd resumes, hcd_bus_resume() calls vhci_bus_resume() which sets > hcd->state as HC_STATE_RUNNING. But after calling vhci_bus_resume(), > hcd_bus_resume() also sets hcd->state as HC_STATE_RUNNING. So, setting > hcd->state in vhci_hcd_resume() is unnecessary. > > Signed-off-by: Suwan Kim <suwan.kim027@gmail.com> > --- > drivers/usb/usbip/vhci_hcd.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c > index e6f378d00fb6..335d61676fb4 100644 > --- a/drivers/usb/usbip/vhci_hcd.c > +++ b/drivers/usb/usbip/vhci_hcd.c > @@ -1252,8 +1252,6 @@ static int vhci_bus_resume(struct usb_hcd *hcd) > spin_lock_irqsave(&vhci->lock, flags); > if (!HCD_HW_ACCESSIBLE(hcd)) > rc = -ESHUTDOWN; > - else > - hcd->state = HC_STATE_RUNNING; > spin_unlock_irqrestore(&vhci->lock, flags); > > return rc; >
Tell me more about why you think this change is needed? How did you test this change?
thanks, -- Shuah
| |