lkml.org 
[lkml]   [2019]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] usbip: Remove repeated setting of hcd->state in vhci_bus_suspend()
From
Date
On 5/6/19 6:55 AM, Suwan Kim wrote:
> When hcd suspends execution, hcd_bus_suspend() calls vhci_bus_suspend()
> which sets hcd->state as HC_STATE_SUSPENDED. But after calling
> vhci_bus_suspend(), hcd_bus_suspend() also sets hcd->state as
> HC_STATE_SUSPENDED.
> So, setting hcd->state in vhci_hcd_suspend() is unnecessary.
>
> Signed-off-by: Suwan Kim <suwan.kim027@gmail.com>
> ---
> drivers/usb/usbip/vhci_hcd.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c
> index 667d9c0ec905..e6f378d00fb6 100644
> --- a/drivers/usb/usbip/vhci_hcd.c
> +++ b/drivers/usb/usbip/vhci_hcd.c
> @@ -1238,10 +1238,6 @@ static int vhci_bus_suspend(struct usb_hcd *hcd)
>
> dev_dbg(&hcd->self.root_hub->dev, "%s\n", __func__);
>
> - spin_lock_irqsave(&vhci->lock, flags);
> - hcd->state = HC_STATE_SUSPENDED;
> - spin_unlock_irqrestore(&vhci->lock, flags);
> -
> return 0;
> }
>
>

Tell me more about why you think this change is needed? How did you test
this change?

thanks,
-- Shuah

\
 
 \ /
  Last update: 2019-05-06 17:14    [W:0.058 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site