Messages in this thread Patch in this message | | | From | Chengguang Xu <> | Subject | [PATCH 1/3] jbd2: fix potential double free | Date | Sun, 5 May 2019 19:01:02 +0800 |
| |
When fail from creating cache jbd2_inode_cache, we will destroy previously created cache jbd2_handle_cache twice. This patch fixes it by removing first destroy in error path.
Signed-off-by: Chengguang Xu <cgxu519@gmail.com> --- fs/jbd2/journal.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c index 382c030cc78b..49797854ccb8 100644 --- a/fs/jbd2/journal.c +++ b/fs/jbd2/journal.c @@ -2642,7 +2642,6 @@ static int __init jbd2_journal_init_handle_cache(void) jbd2_inode_cache = KMEM_CACHE(jbd2_inode, 0); if (jbd2_inode_cache == NULL) { printk(KERN_EMERG "JBD2: failed to create inode cache\n"); - kmem_cache_destroy(jbd2_handle_cache); return -ENOMEM; } return 0; -- 2.20.1
| |