Messages in this thread Patch in this message | | | From | Tomas Bortoli <> | Subject | [PATCH] Bluetooth: hci_bcsp: Fix memory leak in rx_skb | Date | Tue, 28 May 2019 15:42:58 +0200 |
| |
Syzkaller found that it is possible to provoke a memory leak by never freeing rx_skb in struct bcsp_struct.
Fix by freeing in bcsp_close()
Signed-off-by: Tomas Bortoli <tomasbortoli@gmail.com> Reported-by: syzbot+98162c885993b72f19c4@syzkaller.appspotmail.com --- drivers/bluetooth/hci_bcsp.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/drivers/bluetooth/hci_bcsp.c b/drivers/bluetooth/hci_bcsp.c index 1a7f0c82fb36..550ab5b4c8be 100644 --- a/drivers/bluetooth/hci_bcsp.c +++ b/drivers/bluetooth/hci_bcsp.c @@ -759,6 +759,10 @@ static int bcsp_close(struct hci_uart *hu) skb_queue_purge(&bcsp->rel); skb_queue_purge(&bcsp->unrel); + if (bcsp->rx_skb) { + kfree_skb(bcsp->rx_skb); bcsp->rx_skb = NULL; + } + kfree(bcsp); return 0; } -- 2.11.0
| |