Messages in this thread Patch in this message | | | From | Donald Yandt <> | Subject | [PATCH resend] tools/perf/util/machine: Return NULL instead of null-terminating | Date | Tue, 28 May 2019 09:41:28 -0400 |
| |
Return NULL instead of null-terminating version char array when fgets fails due to end-of-file or error.
Signed-off-by: Donald Yandt <donald.yandt@gmail.com> --- tools/perf/util/machine.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index 28a9541c4..6fd877220 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -1235,9 +1235,9 @@ static char *get_kernel_version(const char *root_dir) return NULL;
tmp = fgets(version, sizeof(version), file); - if (!tmp) - *version = '\0'; fclose(file); + if (!tmp) + return NULL;
name = strstr(version, prefix); if (!name) -- 2.20.1
| |