lkml.org 
[lkml]   [2019]   [May]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH 0/4] vsock/virtio: several fixes in the .probe() and .remove()
Date
During the review of "[PATCH] vsock/virtio: Initialize core virtio vsock
before registering the driver", Stefan pointed out some possible issues
in the .probe() and .remove() callbacks of the virtio-vsock driver.

This series tries to solve these issues:
- Patch 1 postpones the 'the_virtio_vsock' assignment at the end of the
.probe() to avoid that some sockets queue works when the initialization
is not finished.
- Patches 2 and 3 stop workers before to call vdev->config->reset(vdev) to
be sure that no one is accessing the device, and adds another flush at the
end of the .remove() to avoid use after free.
- Patch 4 free also used buffers in the virtqueues during the .remove().

Stefano Garzarella (4):
vsock/virtio: fix locking around 'the_virtio_vsock'
vsock/virtio: stop workers during the .remove()
vsock/virtio: fix flush of works during the .remove()
vsock/virtio: free used buffers during the .remove()

net/vmw_vsock/virtio_transport.c | 105 ++++++++++++++++++++++++++-----
1 file changed, 90 insertions(+), 15 deletions(-)

--
2.20.1

\
 
 \ /
  Last update: 2019-05-28 12:57    [W:0.134 / U:0.368 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site