| Date | Mon, 8 Apr 2019 13:30:22 +0700 | From | Mark Brown <> | Subject | Re: [PATCH V2 14/20] spi: tegra114: add support for gpio based cs |
| |
On Thu, Apr 04, 2019 at 05:14:13PM -0700, Sowjanya Komatineni wrote:
> + if (cstate->cs_gpio_valid) { > + int val = (spi->mode & SPI_CS_HIGH) ? 1 : 0; > + > + gpio_set_value(spi->cs_gpio, val); > + }
This is adding new usage of the numbered GPIO interface but we're in the process of trying to transition to GPIO descriptors. Please update this patch to use descriptors instead.
Please also investigate if it's possible to use the core GPIO chip select support more. [unhandled content-type:application/pgp-signature] |