Messages in this thread | | | Date | Sat, 6 Apr 2019 14:01:35 +0300 | From | Sakari Ailus <> | Subject | Re: [PATCH v3 2/2] media:st-mipid02: MIPID02 CSI-2 to PARALLEL bridge driver |
| |
On Tue, Mar 26, 2019 at 02:36:41PM +0000, Mickael GUENE wrote: > Sakari, > > >> +static int bpp_from_code(__u32 code) > >> +{ > >> + switch (code) { > >> + case MEDIA_BUS_FMT_SBGGR8_1X8: > >> + case MEDIA_BUS_FMT_SGBRG8_1X8: > >> + case MEDIA_BUS_FMT_SGRBG8_1X8: > >> + case MEDIA_BUS_FMT_SRGGB8_1X8: > >> + return 8; > >> + case MEDIA_BUS_FMT_SBGGR10_1X10: > >> + case MEDIA_BUS_FMT_SGBRG10_1X10: > >> + case MEDIA_BUS_FMT_SGRBG10_1X10: > >> + case MEDIA_BUS_FMT_SRGGB10_1X10: > >> + return 10; > >> + case MEDIA_BUS_FMT_SBGGR12_1X12: > >> + case MEDIA_BUS_FMT_SGBRG12_1X12: > >> + case MEDIA_BUS_FMT_SGRBG12_1X12: > >> + case MEDIA_BUS_FMT_SRGGB12_1X12: > >> + return 12; > >> + case MEDIA_BUS_FMT_UYVY8_2X8: > > > > This is good for the parallel bus, but on CSI-2 side you should have > > MEDIA_BUS_FMT_UYVY8_1X16 instead. This isn't technically correct for a > > serial bus, but the custom is to use the one sample / pixel formats on the > > serial busses. > > > Should MEDIA_BUS_FMT_BGR888_1X24 be something like > MEDIA_BUS_FMT_BGR888_3X8 for parallel output bus ?
Good point. Yes.
Could you add that format to Documentation/media/uapi/v4l/subdev-formats.rst, please, in a separate patch?
-- Regards,
Sakari Ailus sakari.ailus@linux.intel.com
| |