Messages in this thread Patch in this message | | | Date | Fri, 5 Apr 2019 05:43:11 -0700 | From | tip-bot for Dan Carpenter <> | Subject | [tip:irq/urgent] irqchip/irq-ls1x: Missing error code in ls1x_intc_of_init() |
| |
Commit-ID: 95c5c618fa4349b2ba13aebeabf71911208dfc5e Gitweb: https://git.kernel.org/tip/95c5c618fa4349b2ba13aebeabf71911208dfc5e Author: Dan Carpenter <dan.carpenter@oracle.com> AuthorDate: Fri, 29 Mar 2019 09:21:37 +0300 Committer: Thomas Gleixner <tglx@linutronix.de> CommitDate: Fri, 5 Apr 2019 14:37:56 +0200
irqchip/irq-ls1x: Missing error code in ls1x_intc_of_init()
Currently, when irq_domain_add_linear() fails, the error code does not get set so it returns zero which is wrong. Fix it by setting the appropriate error code.
Fixes: 9e543e22e204 ("irqchip: Add driver for Loongson-1 interrupt controller") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Mukesh Ojha <mojha@codeaurora.org> Cc: Marc Zyngier <marc.zyngier@arm.com> Cc: Jiaxun Yang <jiaxun.yang@flygoat.com> Cc: Jason Cooper <jason@lakedaemon.net> Cc: kernel-janitors@vger.kernel.org Link: https://lkml.kernel.org/r/20190329062136.GQ32613@kadam
--- drivers/irqchip/irq-ls1x.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/drivers/irqchip/irq-ls1x.c b/drivers/irqchip/irq-ls1x.c index 86b72fbd3b45..353111a10413 100644 --- a/drivers/irqchip/irq-ls1x.c +++ b/drivers/irqchip/irq-ls1x.c @@ -130,6 +130,7 @@ static int __init ls1x_intc_of_init(struct device_node *node, NULL); if (!priv->domain) { pr_err("ls1x-irq: cannot add IRQ domain\n"); + err = -ENOMEM; goto out_iounmap; }
| |