Messages in this thread | | | Subject | Re: [PATCH v3 13/13] thermal: qoriq: Add hwmon support | From | Daniel Lezcano <> | Date | Thu, 4 Apr 2019 11:11:56 +0200 |
| |
On 01/04/2019 06:14, Andrey Smirnov wrote: > Expose thermal readings as a HWMON device, so that it could be > accessed using lm-sensors. > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > Cc: Chris Healy <cphealy@gmail.com> > Cc: Lucas Stach <l.stach@pengutronix.de> > Cc: Zhang Rui <rui.zhang@intel.com> > Cc: Eduardo Valentin <edubezval@gmail.com> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org> > Cc: Angus Ainslie (Purism) <angus@akkea.ca> > Cc: linux-imx@nxp.com > Cc: linux-pm@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > --- > drivers/thermal/qoriq_thermal.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/thermal/qoriq_thermal.c b/drivers/thermal/qoriq_thermal.c > index 9d227654f879..7fb9321a0d8c 100644 > --- a/drivers/thermal/qoriq_thermal.c > +++ b/drivers/thermal/qoriq_thermal.c > @@ -12,6 +12,7 @@ > #include <linux/thermal.h> > > #include "thermal_core.h" > +#include "thermal_hwmon.h" > > #define SITES_MAX 16 > > @@ -103,7 +104,10 @@ static int qoriq_tmu_register_tmu_zone(struct device *dev, > case -ENODEV: > continue; > case 0: > - break; > + ret = devm_thermal_add_hwmon_sysfs(tzd); > + if (!ret) > + break; > + /* fallthrough */
Do we really want to disable the thermal zone if the hwmon fails to register ?
> default: > regmap_write(qdata->regmap, REGS_TMR, TMR_DISABLE); > return ret; >
-- <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook | <http://twitter.com/#!/linaroorg> Twitter | <http://www.linaro.org/linaro-blog/> Blog
| |