Messages in this thread | | | From | Naoya Horiguchi <> | Subject | Re: [PATCH] mm/hugetlb: Get rid of NODEMASK_ALLOC | Date | Wed, 3 Apr 2019 05:44:35 +0000 |
| |
On Tue, Apr 02, 2019 at 03:34:15PM +0200, Oscar Salvador wrote: > NODEMASK_ALLOC is used to allocate a nodemask bitmap, ant it does it by > first determining whether it should be allocated in the stack or dinamically > depending on NODES_SHIFT. > Right now, it goes the dynamic path whenever the nodemask_t is above 32 > bytes. > > Although we could bump it to a reasonable value, the largest a nodemask_t > can get is 128 bytes, so since __nr_hugepages_store_common is called from > a rather shore stack we can just get rid of the NODEMASK_ALLOC call here. > > This reduces some code churn and complexity. > > Signed-off-by: Oscar Salvador <osalvador@suse.de>
nice cleanup.
Reviewed-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
| |