lkml.org 
[lkml]   [2019]   [Apr]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm/hugetlb: Get rid of NODEMASK_ALLOC
From
Date
On 4/2/19 6:34 AM, Oscar Salvador wrote:
> NODEMASK_ALLOC is used to allocate a nodemask bitmap, ant it does it by
^
> first determining whether it should be allocated in the stack or dinamically
^
> depending on NODES_SHIFT.
> Right now, it goes the dynamic path whenever the nodemask_t is above 32
> bytes.
>
> Although we could bump it to a reasonable value, the largest a nodemask_t
> can get is 128 bytes, so since __nr_hugepages_store_common is called from
> a rather shore stack we can just get rid of the NODEMASK_ALLOC call here.
^
In addition, the possible call stacks after this routine are not too deep.
Worst case is high order page allocation.

>
> This reduces some code churn and complexity.
>
> Signed-off-by: Oscar Salvador <osalvador@suse.de>

Not a huge deal, but a few typos in the commit message. Thanks for the
clean up.
Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>

--
Mike Kravetz

\
 
 \ /
  Last update: 2019-04-02 22:41    [W:0.131 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site