Messages in this thread | | | Date | Mon, 29 Apr 2019 17:27:23 +0530 | From | Vinod Koul <> | Subject | Re: [PATCH 4/7] dmaengine: sprd: Add device validation to support multiple controllers |
| |
On 15-04-19, 20:14, Baolin Wang wrote: > From: Eric Long <eric.long@unisoc.com> > > Since we can support multiple DMA engine controllers, we should add > device validation in filter function to check if the correct controller > to be requested. > > Signed-off-by: Eric Long <eric.long@unisoc.com> > Signed-off-by: Baolin Wang <baolin.wang@linaro.org> > --- > drivers/dma/sprd-dma.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c > index 0f92e60..9f99d4b 100644 > --- a/drivers/dma/sprd-dma.c > +++ b/drivers/dma/sprd-dma.c > @@ -1020,8 +1020,13 @@ static void sprd_dma_free_desc(struct virt_dma_desc *vd) > static bool sprd_dma_filter_fn(struct dma_chan *chan, void *param) > { > struct sprd_dma_chn *schan = to_sprd_dma_chan(chan); > + struct of_phandle_args *dma_spec = > + container_of(param, struct of_phandle_args, args[0]); > u32 slave_id = *(u32 *)param; > > + if (chan->device->dev->of_node != dma_spec->np)
Are you not using of_dma_find_controller() that does this, so this would be useless!
> + return false; > + > schan->dev_id = slave_id; > return true; > } > -- > 1.7.9.5
-- ~Vinod
| |