lkml.org 
[lkml]   [2019]   [Apr]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 7/7] dmaengine: sprd: Add interrupt support for 2-stage transfer
    On 29-04-19, 20:11, Baolin Wang wrote:
    > On Mon, 29 Apr 2019 at 20:01, Vinod Koul <vkoul@kernel.org> wrote:
    > > On 15-04-19, 20:15, Baolin Wang wrote:

    > > > @@ -429,6 +433,9 @@ static int sprd_dma_set_2stage_config(struct sprd_dma_chn *schan)
    > > > val = chn & SPRD_DMA_GLB_SRC_CHN_MASK;
    > > > val |= BIT(schan->trg_mode - 1) << SPRD_DMA_GLB_TRG_OFFSET;
    > > > val |= SPRD_DMA_GLB_2STAGE_EN;
    > > > + if (schan->int_type != SPRD_DMA_NO_INT)
    > >
    > > Who configure int_type?
    >
    > The int_type is configured through the flags of
    > sprd_dma_prep_slave_sg() by users, see:
    > https://elixir.bootlin.com/linux/v5.1-rc6/source/include/linux/dma/sprd-dma.h#L9

    Please use DMA_PREP_INTERRUPT flag instead!

    --
    ~Vinod

    \
     
     \ /
      Last update: 2019-04-29 16:10    [W:5.385 / U:0.404 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site