Messages in this thread | | | Date | Wed, 24 Apr 2019 15:46:33 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v4 02/26] leds: class: Improve LED and LED flash class registration API |
| |
Hi!
> Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > Cc: Baolin Wang <baolin.wang@linaro.org>
Acked-by: Pavel Machek <pavel@ucw.cz>
> +/** > + * led_classdev_register_ext - register a new object of LED class with > + * init data > + * @parent: LED controller device this LED is driven by > + * @led_cdev: the led_classdev structure for this device > + * @init_data: the LED class device initialization data > + * > + * Returns: 0 on success or negative error value on failure > + */ > +extern int led_classdev_register_ext(struct device *parent, > + struct led_classdev *led_cdev, > + struct led_init_data *init_data); > +#define led_classdev_register(parent, led_cdev) \ > + led_classdev_register_ext(parent, led_cdev, NULL) > +extern int devm_led_classdev_register_ext(struct device *parent, > + struct led_classdev *led_cdev, > + struct led_init_data *init_data); > +#define devm_led_classdev_register(parent, led_cdev) \ > + devm_led_classdev_register_ext(parent, led_cdev, NULL)
Static inline (instead of macro) might be preffered. More type safety and less confusing behaviour in case of errors... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |