Messages in this thread | | | Date | Thu, 18 Apr 2019 14:21:35 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH v4 01/26] ALSA: line6: Avoid polluting led_* namespace |
| |
On Thu 2019-04-18 07:17:54, Takashi Iwai wrote: > On Wed, 17 Apr 2019 22:54:14 +0200, > Jacek Anaszewski wrote: > > > > led_colors clashes with the array of the same name being added > > to the LED class. Do the following amendments to fix this issue > > and the other prospective one. > > > > led_colors -> toneport_led_colors > > led_init_vals -> toneport_led_init_vals > > > > Fixes: f44edd7b2bbed ("ALSA: line6/toneport: Implement LED controls via LED class") > > Signed-off-by: Jacek Anaszewski <jacek.anaszewski@gmail.com> > > Cc: Jaroslav Kysela <perex@perex.cz> > > Cc: Takashi Iwai <tiwai@suse.com> > > Cc: Arnd Bergmann <arnd@arndb.de> > > Looks good. > > Feel free to take my ack: > Reviewed-by: Takashi Iwai <tiwai@suse.de>
I guess this is independend of pretty much everything, and should be taken through the sound tree? Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] | |