| Date | Mon, 15 Apr 2019 22:07:26 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 4.14 03/69] x86/power/64: Use struct desc_ptr for the IDT in struct saved_context |
| |
On Mon 2019-04-15 20:58:21, Greg Kroah-Hartman wrote: > [ Upstream commit 090edbe23ff57940fca7f57d9165ce57a826bd7a ] > > x86_64's saved_context nonsensically used separate idt_limit and > idt_base fields and then cast &idt_limit to struct desc_ptr *. > > This was correct (with -fno-strict-aliasing), but it's confusing, > served no purpose, and required #ifdeffery. Simplify this by > using struct desc_ptr directly. > > No change in functionality.
While this is nice cleanup, I don't think it fixes real bug. I don't think it is suitable for stable. Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html [unhandled content-type:application/pgp-signature] |