lkml.org 
[lkml]   [2019]   [Apr]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 04/12] phy: tegra: add missing of_node_put after of_device_is_available
From
Date
> @@ -260,8 +260,10 @@  tegra_xusb_pad_create(struct tegra_xusb_
> int err;
>
> np = tegra_xusb_find_pad_node(padctl, soc->name);
> - if (!np || !of_device_is_available(np))
> + if (!np || !of_device_is_available(np)) {
> + of_node_put(np);
> return NULL;
> + }
>
> pad = soc->ops->probe(padctl, soc, np);
> if (IS_ERR(pad)) {

How do you think about to move this function call to an additional jump target
for the desired exception handling?

Regards,
Markus

\
 
 \ /
  Last update: 2019-04-14 17:43    [W:0.180 / U:0.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site