Messages in this thread | | | Subject | Re: [PATCH 01/12] arm-cci: add missing of_node_put after of_device_is_available | From | Mukesh Ojha <> | Date | Mon, 1 Apr 2019 18:18:35 +0530 |
| |
On 2/23/2019 6:50 PM, Julia Lawall wrote: > Add an of_node_put when a tested device node is not available. > > The semantic patch that fixes this problem is as follows > (http://coccinelle.lip6.fr): > > // <smpl> > @@ > identifier f; > local idexpression e; > expression x; > @@ > > e = f(...); > ... when != of_node_put(e) > when != x = e > when != e = x > when any > if (<+...of_device_is_available(e)...+>) { > ... when != of_node_put(e) > ( > return e; > | > + of_node_put(e); > return ...; > ) > } > // </smpl> > > Fixes: 896ddd600ba4 ("drivers: bus: check cci device tree node status") > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Cheers, -Mukesh
> > --- > This file doesn't seem to have a maintainer. > > drivers/bus/arm-cci.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff -u -p a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c > --- a/drivers/bus/arm-cci.c > +++ b/drivers/bus/arm-cci.c > @@ -538,8 +538,10 @@ static int cci_probe(void) > struct resource res; > > np = of_find_matching_node(NULL, arm_cci_matches); > - if (!of_device_is_available(np)) > + if (!of_device_is_available(np)) { > + of_node_put(np); > return -ENODEV; > + } > > ret = of_address_to_resource(np, 0, &res); > if (!ret) { >
| |