Messages in this thread Patch in this message | | | From | Bo YU <> | Subject | [PATCH 2/2] net: bonding: fix incorrect type in assignment | Date | Fri, 8 Mar 2019 00:34:05 -0500 |
| |
There are some warning when:
sudo make C=1 CF=-D__CHECK_ENDIAN__ drivers/net/bonding/
drivers/net/bonding/bond_main.c:2438:40: warning: incorrect type in assignment (different base types) drivers/net/bonding/bond_main.c:2438:40: expected restricted __be16 [usertype] vlan_proto drivers/net/bonding/bond_main.c:2438:40: ... rivers/net/bonding/bond_options.c:1089:24: warning: incorrect type in assignment (different base types) drivers/net/bonding/bond_options.c:1089:24: expected restricted __be32 [addressable] [usertype] target drivers/net/bonding/bond_options.c:1089:24: got unsigned long long const [usertype] value
So fix it
Signed-off-by: Bo YU <tsu.yubo@gmail.com> --- drivers/net/bonding/bond_main.c | 2 +- drivers/net/bonding/bond_options.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c index 135fec28daa9..07e52d863e91 100644 --- a/drivers/net/bonding/bond_main.c +++ b/drivers/net/bonding/bond_main.c @@ -2435,7 +2435,7 @@ struct bond_vlan_tag *bond_verify_device_path(struct net_device *start_dev, tags = kcalloc(level + 1, sizeof(*tags), GFP_ATOMIC); if (!tags) return ERR_PTR(-ENOMEM); - tags[level].vlan_proto = VLAN_N_VID; + tags[level].vlan_proto = cpu_to_be16(VLAN_N_VID); return tags; } diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c index da1fc17295d9..3a196999bd1b 100644 --- a/drivers/net/bonding/bond_options.c +++ b/drivers/net/bonding/bond_options.c @@ -1086,7 +1086,7 @@ static int bond_option_arp_ip_targets_set(struct bonding *bond, else netdev_err(bond->dev, "no command found in arp_ip_targets file - use +<addr> or -<addr>\n"); } else { - target = newval->value; + target = cpu_to_be32(newval->value); ret = bond_option_arp_ip_target_add(bond, target); } -- 2.11.0
| |