lkml.org 
[lkml]   [2019]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH] peak_usb: fix clang build warning
On Thu, Mar 7, 2019 at 4:31 PM Nathan Chancellor
<natechancellor@gmail.com> wrote:
>
> On Thu, Mar 07, 2019 at 11:31:55AM +0100, Arnd Bergmann wrote:
> > Clang points out undefined behavior when building the pcan_usb_pro driver:
> >
> > drivers/net/can/usb/peak_usb/pcan_usb_pro.c:136:15: error: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]
> >
> > Changing the function prototype to avoid argument promotion in the
> > varargs call avoids the warning, and should make this well-defined.
> >
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>
> Link: https://github.com/ClangBuiltLinux/linux/issues/109
> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>

Thanks!

> I wonder if the format specifier in the pr_err statement at the end of
> this function should be updated.

I think it's still ok as it is.

Arnd

\
 
 \ /
  Last update: 2019-03-07 16:39    [W:0.040 / U:0.632 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site