lkml.org 
[lkml]   [2019]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] peak_usb: fix clang build warning
From
From: Arnd Bergmann <arnd@arndb.de>
Date: Thu, 7 Mar 2019 11:31:55 +0100

> Clang points out undefined behavior when building the pcan_usb_pro driver:
>
> drivers/net/can/usb/peak_usb/pcan_usb_pro.c:136:15: error: passing an object that undergoes default argument promotion to 'va_start' has undefined behavior [-Werror,-Wvarargs]
>
> Changing the function prototype to avoid argument promotion in the
> varargs call avoids the warning, and should make this well-defined.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied.

\
 
 \ /
  Last update: 2019-03-07 18:41    [W:0.047 / U:2.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site