Messages in this thread Patch in this message | | | From | Arnd Bergmann <> | Subject | [PATCH] iio: stmpe-adc: avoid harmless clang warning | Date | Fri, 22 Mar 2019 15:08:39 +0100 |
| |
Clang points out a control flow bug, which happens to be harmless:
drivers/iio/adc/stmpe-adc.c:204:13: error: variable 'data' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
The warning is sensible here, so let's just avoid the case by adding appropriate error handling.
Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/iio/adc/stmpe-adc.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/drivers/iio/adc/stmpe-adc.c b/drivers/iio/adc/stmpe-adc.c index 37f4b74a5d32..ed3817c5c896 100644 --- a/drivers/iio/adc/stmpe-adc.c +++ b/drivers/iio/adc/stmpe-adc.c @@ -205,6 +205,8 @@ static irqreturn_t stmpe_adc_isr(int irq, void *dev_id) /* Read value */ stmpe_block_read(info->stmpe, STMPE_REG_TEMP_DATA, 2, (u8 *) &data); + } else { + return IRQ_NONE; } info->value = (u32) be16_to_cpu(data); -- 2.20.0
| |