lkml.org 
[lkml]   [2019]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH] ARM: mm: make use of new memblocks_present() helper
On Tue, Mar 19, 2019 at 12:13:57PM -0600, Logan Gunthorpe wrote:
> Cleanup the arm_memory_present() function seeing it's very
> similar to other arches.
>
> The new memblocks_present() helper checks for node ids which the
> arm version did not. However, this is equivalent seeing
> HAVE_MEMBLOCK_NODE_MAP should be false in this arch and therefore
> memblock_get_region_node() should return 0.
>
> Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
> Cc: Russell King <linux@armlinux.org.uk>
> Cc: Kees Cook <keescook@chromium.org>
> Cc: Philip Derrin <philip@cog.systems>
> Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org>
> Cc: Nicolas Pitre <nicolas.pitre@linaro.org>

Reviewed-by: Mike Rapoport <rppt@linux.ibm.com>

Strangely, I've got a feeling I've already reviewed such patch from a
different person...

> ---
> arch/arm/mm/init.c | 17 +----------------
> 1 file changed, 1 insertion(+), 16 deletions(-)
>
> This is just a resend.
>
> diff --git a/arch/arm/mm/init.c b/arch/arm/mm/init.c
> index 478ea8b7db87..6c50dd407ba8 100644
> --- a/arch/arm/mm/init.c
> +++ b/arch/arm/mm/init.c
> @@ -182,21 +182,6 @@ int pfn_valid(unsigned long pfn)
> EXPORT_SYMBOL(pfn_valid);
> #endif
>
> -#ifndef CONFIG_SPARSEMEM
> -static void __init arm_memory_present(void)
> -{
> -}
> -#else
> -static void __init arm_memory_present(void)
> -{
> - struct memblock_region *reg;
> -
> - for_each_memblock(memory, reg)
> - memory_present(0, memblock_region_memory_base_pfn(reg),
> - memblock_region_memory_end_pfn(reg));
> -}
> -#endif
> -
> static bool arm_memblock_steal_permitted = true;
>
> phys_addr_t __init arm_memblock_steal(phys_addr_t size, phys_addr_t align)
> @@ -292,7 +277,7 @@ void __init bootmem_init(void)
> * Sparsemem tries to allocate bootmem in memory_present(),
> * so must be done after the fixed reservations
> */
> - arm_memory_present();
> + memblocks_present();
>
> /*
> * sparse_init() needs the bootmem allocator up and running.
> --
> 2.20.1
>

--
Sincerely yours,
Mike.

\
 
 \ /
  Last update: 2019-03-19 21:44    [W:0.067 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site