Messages in this thread | | | From | Logan Gunthorpe <> | Date | Tue, 19 Mar 2019 14:50:25 -0600 | Subject | Re: [PATCH] ARM: mm: make use of new memblocks_present() helper |
| |
On 2019-03-19 2:42 p.m., Mike Rapoport wrote: > On Tue, Mar 19, 2019 at 12:13:57PM -0600, Logan Gunthorpe wrote: >> Cleanup the arm_memory_present() function seeing it's very >> similar to other arches. >> >> The new memblocks_present() helper checks for node ids which the >> arm version did not. However, this is equivalent seeing >> HAVE_MEMBLOCK_NODE_MAP should be false in this arch and therefore >> memblock_get_region_node() should return 0. >> >> Signed-off-by: Logan Gunthorpe <logang@deltatee.com> >> Cc: Russell King <linux@armlinux.org.uk> >> Cc: Kees Cook <keescook@chromium.org> >> Cc: Philip Derrin <philip@cog.systems> >> Cc: "Steven Rostedt (VMware)" <rostedt@goodmis.org> >> Cc: Nicolas Pitre <nicolas.pitre@linaro.org> > > Reviewed-by: Mike Rapoport <rppt@linux.ibm.com> > > Strangely, I've got a feeling I've already reviewed such patch from a > different person...
You're probably referring to [1] which was for arm64 and was redundant as my patch for that architecture was already picked up by Catalin.
I was the person who originally introduced memblocks_present() and I'm still hoping to get the cleanup patches for the arm and sh arches to be picked up.
Thanks,
Logan
[1] https://lore.kernel.org/lkml/20190210093738.30923-1-peng.fan@nxp.com/T/#u
| |