Messages in this thread | | | Subject | Re: [PATCH] net: stmmac: fix memory corruption with large MTUs | From | Jose Abreu <> | Date | Tue, 19 Mar 2019 14:42:32 +0000 |
| |
On 3/19/2019 11:07 AM, Koskinen, Aaro (Nokia - FI/Espoo) wrote: > Hi, > > From: Jose Abreu [jose.abreu@synopsys.com]: >> On 3/18/2019 9:36 PM, Aaro Koskinen wrote: >>> /* Fill DES3 in case of RING mode */ >>> - if (priv->dma_buf_sz >= BUF_SIZE_8KiB) >>> + if (priv->dma_buf_sz == BUF_SIZE_16KiB) >> >> Shouldn't this be: "if (priv->dma_buf_sz > BUF_SIZE_8KiB)" ? > > I think it should be the same as in stmmac_init_rx_buffers(): > > if (priv->dma_buf_sz == BUF_SIZE_16KiB) > stmmac_init_desc3(priv, p); > > A. >
Hmm, yeah makes sense. I was under impression that XGMAC had a > 16KB buffer but I was wrong.
This change looks okay then.
Acked-by: Jose Abreu <joabreu@synopsys.com>
Thanks, Jose Miguel Abreu
| |