lkml.org 
[lkml]   [2019]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] net: stmmac: fix memory corruption with large MTUs
Date
Hi,

From: Jose Abreu [jose.abreu@synopsys.com]:
> On 3/18/2019 9:36 PM, Aaro Koskinen wrote:
> > /* Fill DES3 in case of RING mode */
> > - if (priv->dma_buf_sz >= BUF_SIZE_8KiB)
> > + if (priv->dma_buf_sz == BUF_SIZE_16KiB)
>
> Shouldn't this be: "if (priv->dma_buf_sz > BUF_SIZE_8KiB)" ?

I think it should be the same as in stmmac_init_rx_buffers():

if (priv->dma_buf_sz == BUF_SIZE_16KiB)
stmmac_init_desc3(priv, p);

A.

\
 
 \ /
  Last update: 2019-03-19 12:08    [W:1.131 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site