Messages in this thread Patch in this message | | | Date | Wed, 20 Mar 2019 11:48:51 +1100 | From | Stephen Rothwell <> | Subject | linux-next: build failure after merge of the scsi tree |
| |
Hi James,
After merging the scsi tree, today's linux-next build (powerpc ppc64_defconfig) failed like this:
In file included from drivers/scsi/lpfc/lpfc_debugfs.c:46: drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_idiag_queacc_write': drivers/scsi/lpfc/lpfc_sli4.h:1083:14: error: inlining failed in call to always_inline 'lpfc_sli4_qe': function body not available inline void *lpfc_sli4_qe(struct lpfc_queue *, uint16_t); ^~~~~~~~~~~~ drivers/scsi/lpfc/lpfc_debugfs.c:4488:12: note: called from here pentry = lpfc_sli4_qe(pque, index); ^~~~~~~~~~~~~~~~~~~~~~~~~ In file included from drivers/scsi/lpfc/lpfc_debugfs.c:46: drivers/scsi/lpfc/lpfc_sli4.h:1083:14: error: inlining failed in call to always_inline 'lpfc_sli4_qe': function body not available inline void *lpfc_sli4_qe(struct lpfc_queue *, uint16_t); ^~~~~~~~~~~~ drivers/scsi/lpfc/lpfc_debugfs.c:4488:12: note: called from here pentry = lpfc_sli4_qe(pque, index); ^~~~~~~~~~~~~~~~~~~~~~~~~
Caused by commit
9afbee3d62a4 ("scsi: lpfc: Reduce memory footprint for lpfc_queue")
I applied the following fix patch for today.
From: Stephen Rothwell <sfr@canb.auug.org.au> Date: Wed, 20 Mar 2019 11:44:21 +1100 Subject: [PATCH] scsi: lpfc: remove inappropriate inline
Fixes: 9afbee3d62a4 ("scsi: lpfc: Reduce memory footprint for lpfc_queue") Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au> --- drivers/scsi/lpfc/lpfc_sli4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_sli4.h b/drivers/scsi/lpfc/lpfc_sli4.h index bd5b5c3de35e..6670c6e7e28d 100644 --- a/drivers/scsi/lpfc/lpfc_sli4.h +++ b/drivers/scsi/lpfc/lpfc_sli4.h @@ -1080,4 +1080,4 @@ int lpfc_sli4_post_status_check(struct lpfc_hba *); uint8_t lpfc_sli_config_mbox_subsys_get(struct lpfc_hba *, LPFC_MBOXQ_t *); uint8_t lpfc_sli_config_mbox_opcode_get(struct lpfc_hba *, LPFC_MBOXQ_t *); void lpfc_sli4_ras_dma_free(struct lpfc_hba *phba); -inline void *lpfc_sli4_qe(struct lpfc_queue *, uint16_t); +void *lpfc_sli4_qe(struct lpfc_queue *, uint16_t); -- 2.20.1 -- Cheers, Stephen Rothwell [unhandled content-type:application/pgp-signature] | |