Messages in this thread | | | From | Martin Blumenstingl <> | Date | Mon, 18 Mar 2019 21:02:13 +0100 | Subject | Re: [PATCH v2 1/8] arm64: dts: meson: g12a: Add AO Clock + Reset Controller support |
| |
Hi Neil,
On Mon, Mar 18, 2019 at 10:59 AM Neil Armstrong <narmstrong@baylibre.com> wrote: > > Add nodes and properties for the AO Clocks and Resets. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> > --- > arch/arm64/boot/dts/amlogic/meson-g12a.dtsi | 18 ++++++++++++++++++ > 1 file changed, 18 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi > index 31ddf9444b3e..5c0983edf837 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-g12a.dtsi > @@ -4,6 +4,7 @@ > */ > > #include <dt-bindings/gpio/gpio.h> > +#include <dt-bindings/clock/g12a-clkc.h> > #include <dt-bindings/interrupt-controller/irq.h> > #include <dt-bindings/interrupt-controller/arm-gic.h> > > @@ -122,6 +123,23 @@ > #size-cells = <2>; > ranges = <0x0 0x0 0x0 0xff800000 0x0 0x100000>; > > + rti: sys-ctrl@0 { > + compatible = "amlogic,meson-gx-ao-sysctrl", > + "simple-mfd", "syscon"; > + reg = <0x0 0x0 0x0 0x100>; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges = <0x0 0x0 0x0 0x0 0x0 0x100>; sorry for noticing this only very late: I missed the #address-cells, #size-cells and ranges property in my last review do you have any change queued which requires this? my understanding is that the drivers for all RTI children should use the register offsets relative to the RTI start address. In that case the child nodes neither have a unit-address nor a reg property, making the last three properties unnecessary.
Regards Martin
| |