Messages in this thread Patch in this message | | | From | Aditya Pakki <> | Subject | [PATCH] mwifiex: Fix potential NULL pointer dereference | Date | Wed, 13 Mar 2019 13:42:29 -0500 |
| |
dev_alloc_skb can fail and return a NULL pointer. The patch avoids a potential NULL pointer dereference and returns -ENOMEM.
Signed-off-by: Aditya Pakki <pakki001@umn.edu> --- drivers/net/wireless/marvell/mwifiex/cmdevt.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/drivers/net/wireless/marvell/mwifiex/cmdevt.c b/drivers/net/wireless/marvell/mwifiex/cmdevt.c index 60db2b969e20..4e2fa972a78a 100644 --- a/drivers/net/wireless/marvell/mwifiex/cmdevt.c +++ b/drivers/net/wireless/marvell/mwifiex/cmdevt.c @@ -341,6 +341,9 @@ static int mwifiex_dnld_sleep_confirm_cmd(struct mwifiex_adapter *adapter) sleep_cfm_tmp = dev_alloc_skb(sizeof(struct mwifiex_opt_sleep_confirm) + MWIFIEX_TYPE_LEN); + if (!sleep_cfm_tmp) + return -ENOMEM; + skb_put(sleep_cfm_tmp, sizeof(struct mwifiex_opt_sleep_confirm) + MWIFIEX_TYPE_LEN); put_unaligned_le32(MWIFIEX_USB_TYPE_CMD, sleep_cfm_tmp->data); -- 2.17.1
| |