lkml.org 
[lkml]   [2019]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/boot: clean up headers
Hi Nick,

On Fri, 1 Mar 2019 16:07:14 -0800 Nick Desaulniers <ndesaulniers@google.com> wrote:
>
> It turns out that arch/x86/boot/string.c doesn't actually need
> linux/kernel.h, simply linux/limits.h and linux/compiler.h. Include them,
> and sort the headers alphabetically.

One small nit: please do not do the sort in the same commit as the bug
fix. It just complicates the review and has (a remote) possibility of
adding a new problem. (Not a big issue here, but in general cleanups
and bug fixes should be separate.)
--
Cheers,
Stephen Rothwell
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-03-02 03:29    [W:0.061 / U:0.948 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site