Messages in this thread | | | Date | Tue, 5 Mar 2019 09:51:00 +1100 | From | Stephen Rothwell <> | Subject | Re: [PATCH v2] x86/boot: clean up headers |
| |
Hi Nick,
On Mon, 4 Mar 2019 09:50:16 -0800 Nick Desaulniers <ndesaulniers@google.com> wrote: > > Changes V1 -> V2: > * Add Reviewed, Tested, Suggested tags. > * Drop linux/types.h; it's included in linux/limits.h. > > My original intention was to unsort the headers (sorted in V1), but if > we drop the out of place linux/types.h, then we can insert the two more > specific headers in alphabetic order.
I don't understand why you care about the include file ordering.
Also, since this file uses things from linux/types.h, I would argue that we need the explicit include of linux/types.h. Just imagine if someone at a later date reomves the linux/types.h include from linux/limits.h (however unlikely that is).
Just do your bug fix.
-- Cheers, Stephen Rothwell [unhandled content-type:application/pgp-signature] | |