Messages in this thread Patch in this message | | | From | Laurent Vivier <> | Subject | [PATCH v2] powerpc/mm: move a KERN_WARNING message to pr_debug() | Date | Tue, 5 Feb 2019 21:21:33 +0100 |
| |
resize_hpt_for_hotplug() reports a warning when it cannot increase the hash page table ("Unable to resize hash page table to target order") but this is not blocking and can make user thinks something has not worked properly. As we move the message to the debug area, report again the ENODEV error.
If the operation cannot be done the real error message will be reported by arch_add_memory() if create_section_mapping() fails.
Fixes: 7339390d772dd powerpc/pseries: Don't give a warning when HPT resizing isn't available Signed-off-by: Laurent Vivier <lvivier@redhat.com> ---
Notes: v2: - use pr_debug instead of printk(KERN_DEBUG - remove check for ENODEV
arch/powerpc/mm/hash_utils_64.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c index 0cc7fbc3bd1c..6a0cc4eb2c83 100644 --- a/arch/powerpc/mm/hash_utils_64.c +++ b/arch/powerpc/mm/hash_utils_64.c @@ -777,10 +777,9 @@ void resize_hpt_for_hotplug(unsigned long new_mem_size) int rc; rc = mmu_hash_ops.resize_hpt(target_hpt_shift); - if (rc && (rc != -ENODEV)) - printk(KERN_WARNING - "Unable to resize hash page table to target order %d: %d\n", - target_hpt_shift, rc); + if (rc) + pr_debug("Unable to resize hash page table to target order %d: %d\n", + target_hpt_shift, rc); } } -- 2.20.1
| |