Messages in this thread Patch in this message | | | From | Shuah Khan <> | Subject | [PATCH] media: replace WARN_ON in __media_pipeline_start() | Date | Fri, 22 Feb 2019 17:17:09 -0700 |
| |
__media_pipeline_start() does WARN_ON() when active pipe doesn't match the input arg entity's pipe.
Replace WARN_ON with a conditional and error message that includes names of both entities.
Signed-off-by: Shuah Khan <shuah@kernel.org> --- drivers/media/media-entity.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c index 0b1cb3559140..757c641b7409 100644 --- a/drivers/media/media-entity.c +++ b/drivers/media/media-entity.c @@ -436,7 +436,10 @@ __must_check int __media_pipeline_start(struct media_entity *entity, entity->stream_count++; - if (WARN_ON(entity->pipe && entity->pipe != pipe)) { + if (entity->pipe && entity->pipe != pipe) { + pr_err("Pipe active for %s. Can't start for %s\n", + entity->name, + entity_err->name); ret = -EBUSY; goto error; } -- 2.17.1
| |