lkml.org 
[lkml]   [2019]   [Feb]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Subject[PATCH V4 0/4] genirq/affinity: add .calc_sets for improving IRQ allocation & spread
Date
Hi,

Currently pre-caculated set vectors are provided by driver for
allocating & spread vectors. This way only works when drivers passes
same 'max_vecs' and 'min_vecs' to pci_alloc_irq_vectors_affinity(),
also requires driver to retry the allocating & spread.

As Bjorn and Keith mentioned, the current usage & interface for irq sets
is a bit awkward because the retrying should have been avoided by providing
one resonable 'min_vecs'. However, if 'min_vecs' isn't same with
'max_vecs', number of the allocated vectors is unknown before calling
pci_alloc_irq_vectors_affinity(), then each set's vectors can't be
pre-caculated.

Add a new callback of .calc_sets into 'struct irq_affinity' so that
driver can caculate set vectors after IRQ vector is allocated and
before spread IRQ vectors.

V4:
- re-writen changelogs by Thomas Gleixner
- merge patch of removing 'const' into the patch
for adding new callback

V3:
- don't mark 'affd' as const in related functions
- add sanity check on affd->nr_sets
- remove the local variable of 'nr_sets' in irq_create_affinity_masks
- set .nr_sets as 2 in nvme
- update comment in msi.c

V2:
- add .calc_sets instead of .setup_affinity() which is easy to
be abused by drivers

Ming Lei (4):
genirq/affinity: store interrupt sets size in 'struct irq_affinity'
genirq/affinity: add new callback for caculating interrupt sets size
nvme-pci: Simplify interrupt allocation
PCI: Document .calc_sets as required in case of multiple interrupt
sets

drivers/nvme/host/pci.c | 63 ++++++++++++-----------------------------------
drivers/pci/msi.c | 32 +++++++++++++-----------
include/linux/interrupt.h | 13 +++++++---
include/linux/pci.h | 4 +--
kernel/irq/affinity.c | 26 ++++++++++++-------
5 files changed, 62 insertions(+), 76 deletions(-)

--
2.9.5

\
 
 \ /
  Last update: 2019-02-14 13:25    [W:0.066 / U:1.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site